SMF Arcade v2.55

Started by Skhilled, December 26, 2017, 02:21:39 AM

Previous topic - Next topic

0 Members and 3 Guests are viewing this topic.

Skhilled

The latest version has now been released. Have fun!

- fixed issue with maintenance

- array needed to be parent paths only

https://www.docskillz.com/docs/index.php?action=downloads;sa=view;down=50

lurkalot

Couple of problems with this release, I've noticed so far. Running on SMF 2.0.15 locally in Xampp.

The comments you enter aren't saved when you finish a game.  But if you click the edit icon on the comment you can enter the comment and it saves.

Images are missing from the arcade stats page. same as here, https://www.docskillz.com/docs/index.php?action=arcade;sa=stats and here, https://web-develop.ca/index.php?action=arcade;sa=stats

EDIT:  And some errors in log,

Type of error: Undefined 
http://localhost/smf2014/index.php?action=arcade;sa=highscore;xml;
8: Undefined index: comment
File: C:/xampp/htdocs/smf2014/Sources/Subs-ArcadePlus.php
Line: 848

Type of error: Undefined 
http://localhost/smf2014/index.php?action=arcade;sa=highscore;xml;
8: Undefined index: comment
File: C:/xampp/htdocs/smf2014/Sources/Subs-ArcadePlus.php
Line: 848 

Type of error: General 
http://localhost/smf2014/index.php?action=admin;area=managegames;sa=install2;sesc
2: Invalid argument supplied for foreach()
File: C:/xampp/htdocs/smf2014/Sources/Subs-ArcadeAdmin.php
Line: 392 

Type of error: Undefined 
http://localhost/smf2014/index.php?action=admin;area=managegames;sa=install2;sesc
8: Undefined variable: masterGameinfo
File: C:/xampp/htdocs/smf2014/Sources/Subs-ArcadeAdmin.php
Line: 392 

Skhilled

Thanks, for the update, Mick.

lurkalot

Quote from: Skhilled on December 26, 2017, 08:28:18 AM
Thanks, for the update, Mick.

You're welcome.  Also reported these issues on the GitHub repo.

Chen Zhen


The 2 installation errors were due to the html5 pacman game installation from one of the html5 gamepacks.
It is an issue with the arcade installer itself which I just fixed locally but haven't updated GitHub or my site yet.
It was due to duplicate internal names (swf pacman with the same internal name).

Prior to updating I will have to fix the other errors you just reported.

Chen Zhen


Comments are working for me with v1 and html5 games.
I will attempt to find the specific game you were playing in your image and test it.

Does this occur for all your games?

lurkalot

Quote from: Chen Zhen on December 26, 2017, 01:33:00 PM

Comments are working for me with v1 and html5 games.
I will attempt to find the specific game you were playing in your image and test it.

Does this occur for all your games?

Seems to happen with all the games I've played so far.  This game on your site for example https://web-develop.ca/index.php?index.php;action=arcade;sa=play;game=180

I left a comment on the scores, but as you can see they are not there,  The image attached is me adding a comment, and clicking the save button to the right of it.

Skhilled

I just realized that this site has not been updated to the latest version of the arcade and may be why you do not see the images in the admin, etc....not sure tho... Same goes for OFF. The versions installed at both sites are the RC5 version not 2.55. I haven't gotten around to installing them yet.

lurkalot

Steve, I'm testing the one from the download link you posted in the first post, those images are missing in that one.  I think by the looks of it Chen Zhen has fixed those images now on his site, https://web-develop.ca/index.php?action=arcade;sa=stats

lurkalot

Actually looking at the installer it appears the missing image is there for uninstall, but not for install. 

Themes/default/images/arc_icons/gold.gif

Skhilled

Yeah, I know. Just saying cause I've just realize that I've never upgraded. Been pretty busy lately. But now the dust has settled I can get back to things.

Chen Zhen


The installer uses the entire arc_icons folder but for the uninstall it opts specific default files.
This is because people have the option to add their own icons/images that they may want to keep including ones added by uploading category icons.

The issue was not because of a missing image file but was due to me changing the file path location and neglecting to update the stats template.
It has been fixed now as well as some other issues.

Comments are working for me.
What browser are you using?
Perhaps it is browser specific but I would like to know so I can resolve the problem.

Skhilled

Btw, in the arcade footer it says RC5 but in Packages it says 2.55 which confused me into thinking the older version was still installed here. You will soon have to change the copyright date as well.


EDIT: The arcade has been updated here to the latest github version.

lurkalot

Quote from: Skhilled on December 28, 2017, 01:31:34 AM

EDIT: The arcade has been updated here to the latest github version.


Looks like those images for the stats page are there now.   Have you got the comments turned off in the arcade though, there doesn't seem to be a way to leave or edit a comment atm.

Skhilled

Try it now. It comments worked for me but there isn't a setting just for enable/disable comments. But there is one for editing them and I've enable it.