Docskillz

The Good Stuff => SMF Arcade Support => Topic started by: Skhilled on December 26, 2017, 02:21:39 AM

Title: SMF Arcade v2.55
Post by: Skhilled on December 26, 2017, 02:21:39 AM
The latest version has now been released. Have fun!

- fixed issue with maintenance

- array needed to be parent paths only

https://www.docskillz.com/docs/index.php?action=downloads;sa=view;down=50 (https://www.docskillz.com/docs/index.php?action=downloads;sa=view;down=50)
Title: Re: SMF Arcade v2.55
Post by: lurkalot on December 26, 2017, 06:17:30 AM
Couple of problems with this release, I've noticed so far. Running on SMF 2.0.15 locally in Xampp.

The comments you enter aren't saved when you finish a game.  But if you click the edit icon on the comment you can enter the comment and it saves.

Images are missing from the arcade stats page. same as here, https://www.docskillz.com/docs/index.php?action=arcade;sa=stats and here, https://web-develop.ca/index.php?action=arcade;sa=stats

EDIT:  And some errors in log,

Type of error: Undefined 
http://localhost/smf2014/index.php?action=arcade;sa=highscore;xml;
8: Undefined index: comment
File: C:/xampp/htdocs/smf2014/Sources/Subs-ArcadePlus.php
Line: 848

Type of error: Undefined 
http://localhost/smf2014/index.php?action=arcade;sa=highscore;xml;
8: Undefined index: comment
File: C:/xampp/htdocs/smf2014/Sources/Subs-ArcadePlus.php
Line: 848 

Type of error: General 
http://localhost/smf2014/index.php?action=admin;area=managegames;sa=install2;sesc
2: Invalid argument supplied for foreach()
File: C:/xampp/htdocs/smf2014/Sources/Subs-ArcadeAdmin.php
Line: 392 

Type of error: Undefined 
http://localhost/smf2014/index.php?action=admin;area=managegames;sa=install2;sesc
8: Undefined variable: masterGameinfo
File: C:/xampp/htdocs/smf2014/Sources/Subs-ArcadeAdmin.php
Line: 392 
Title: Re: SMF Arcade v2.55
Post by: Skhilled on December 26, 2017, 08:28:18 AM
Thanks, for the update, Mick.
Title: Re: SMF Arcade v2.55
Post by: lurkalot on December 26, 2017, 08:41:43 AM
Quote from: Skhilled on December 26, 2017, 08:28:18 AM
Thanks, for the update, Mick.

You're welcome.  Also reported these issues on the GitHub repo.
Title: Re: SMF Arcade v2.55
Post by: Chen Zhen on December 26, 2017, 01:27:35 PM

The 2 installation errors were due to the html5 pacman game installation from one of the html5 gamepacks.
It is an issue with the arcade installer itself which I just fixed locally but haven't updated GitHub or my site yet.
It was due to duplicate internal names (swf pacman with the same internal name).

Prior to updating I will have to fix the other errors you just reported.
Title: Re: SMF Arcade v2.55
Post by: Chen Zhen on December 26, 2017, 01:33:00 PM

Comments are working for me with v1 and html5 games.
I will attempt to find the specific game you were playing in your image and test it.

Does this occur for all your games?
Title: Re: SMF Arcade v2.55
Post by: lurkalot on December 26, 2017, 04:52:36 PM
Quote from: Chen Zhen on December 26, 2017, 01:33:00 PM

Comments are working for me with v1 and html5 games.
I will attempt to find the specific game you were playing in your image and test it.

Does this occur for all your games?

Seems to happen with all the games I've played so far.  This game on your site for example https://web-develop.ca/index.php?index.php;action=arcade;sa=play;game=180

I left a comment on the scores, but as you can see they are not there,  The image attached is me adding a comment, and clicking the save button to the right of it.
Title: Re: SMF Arcade v2.55
Post by: Skhilled on December 27, 2017, 11:26:29 AM
I just realized that this site has not been updated to the latest version of the arcade and may be why you do not see the images in the admin, etc....not sure tho... Same goes for OFF. The versions installed at both sites are the RC5 version not 2.55. I haven't gotten around to installing them yet.
Title: Re: SMF Arcade v2.55
Post by: lurkalot on December 27, 2017, 12:15:48 PM
Steve, I'm testing the one from the download link you posted in the first post, those images are missing in that one.  I think by the looks of it Chen Zhen has fixed those images now on his site, https://web-develop.ca/index.php?action=arcade;sa=stats
Title: Re: SMF Arcade v2.55
Post by: lurkalot on December 27, 2017, 12:44:29 PM
Actually looking at the installer it appears the missing image is there for uninstall, but not for install. 

Themes/default/images/arc_icons/gold.gif
Title: Re: SMF Arcade v2.55
Post by: Skhilled on December 27, 2017, 07:07:05 PM
Yeah, I know. Just saying cause I've just realize that I've never upgraded. Been pretty busy lately. But now the dust has settled I can get back to things.
Title: Re: SMF Arcade v2.55
Post by: Chen Zhen on December 28, 2017, 01:28:26 AM

The installer uses the entire arc_icons folder but for the uninstall it opts specific default files.
This is because people have the option to add their own icons/images that they may want to keep including ones added by uploading category icons.

The issue was not because of a missing image file but was due to me changing the file path location and neglecting to update the stats template.
It has been fixed now as well as some other issues.

Comments are working for me.
What browser are you using?
Perhaps it is browser specific but I would like to know so I can resolve the problem.
Title: Re: SMF Arcade v2.55
Post by: Skhilled on December 28, 2017, 01:31:34 AM
Btw, in the arcade footer it says RC5 but in Packages it says 2.55 which confused me into thinking the older version was still installed here. You will soon have to change the copyright date as well.


EDIT: The arcade has been updated here to the latest github version.
Title: Re: SMF Arcade v2.55
Post by: lurkalot on December 28, 2017, 05:18:55 AM
Quote from: Skhilled on December 28, 2017, 01:31:34 AM

EDIT: The arcade has been updated here to the latest github version.


Looks like those images for the stats page are there now.   Have you got the comments turned off in the arcade though, there doesn't seem to be a way to leave or edit a comment atm.
Title: Re: SMF Arcade v2.55
Post by: Skhilled on December 28, 2017, 08:59:04 AM
Try it now. It comments worked for me but there isn't a setting just for enable/disable comments. But there is one for editing them and I've enable it.
Title: Re: SMF Arcade v2.55
Post by: lurkalot on December 28, 2017, 01:56:35 PM
Quote from: Skhilled on December 28, 2017, 08:59:04 AM
Try it now. It comments worked for me but there isn't a setting just for enable/disable comments. But there is one for editing them and I've enable it.

OK, so they are active for me again now, so looks like the setting for the edit comments turns them on and off.  Comments still not saving for me though.

Quote from: Chen Zhen on December 28, 2017, 01:28:26 AM

Comments are working for me.
What browser are you using?
Perhaps it is browser specific but I would like to know so I can resolve the problem.


Tried in Edge and IE11 haven't tried the others yet.  This game for example, https://www.docskillz.com/docs/index.php?action=arcade;sa=play;game=54

When I click send score, it saves the score and gives me a box to leave a comment in.  Clicking save the page refreshes the page getting rid of the comment input box as expected, but as you can see there is no comments against my scores.
Title: Re: SMF Arcade v2.55
Post by: Skhilled on December 28, 2017, 02:43:35 PM
It works in chrome.


Confirmed! Comments do not work in Edge.
Title: Re: SMF Arcade v2.55
Post by: lurkalot on December 28, 2017, 03:20:44 PM
Thanks for confirming that Steve. ;)

Now another problem I've noticed, the category icons.  Uploaded a gif for each of my cats, and they uploaded and show on the arcade admin page ok.  But viewing the categories in the arcade they don't show.  file name get changed somehow from Defence_Games to Defence_Games.gif.gif

or another example, see screenshots, 1st one shows the image in arcade admin.  Second one shows missing image, and properties showing the double gif on the end of the file name.
Title: Re: SMF Arcade v2.55
Post by: Skhilled on December 28, 2017, 03:22:15 PM
Looks like a coding issue of sorts.
Title: Re: SMF Arcade v2.55
Post by: lurkalot on December 31, 2017, 08:03:27 AM
Quote from: Skhilled on December 28, 2017, 03:22:15 PM
Looks like a coding issue of sorts.

Chen Zhen,  I noticed you added some more fixes over at the GitHub repo a few hours ago, https://github.com/Underdog-01/SMF-Arcade-RC5/commit/84a9f5941a38bb5d0d9cd0a3e91b41234ed264bd

now running this on my test site. http://cctestsite.info/forums/index.php?action=arcade Category images are now working.  Comments are still not saving in IE11 but not sure if you've tried fixing that yet.

Apart from that all looking good atm. Thank you.
Title: Re: SMF Arcade v2.55
Post by: lurkalot on December 31, 2017, 10:06:53 AM
OK, a new issue since those fixes were applied.

Look at a score and just clicking the edit comment button now generates a error in the log.  Also clicking the save button no longer does anything.

Type of error: Undefined 
http://cctestsite.info/forums/index.php?action=arcade;sa=highscore;xml;
8: Undefined index: comment
File: /home/cameracr/public_html/cctestsite.info/forums/Sources/Subs-ArcadePlus.php
Line: 848

This line $output[] = ' ' . Array2XML($data, null, $elements[$k], $indent++);

A few lines of code including that line, from /Sources/Subs-ArcadePlus.php. elseif (is_numeric($k))
fatal_lang_error('arcade_internal_error', false);
else
{
if (!empty($elements) && !((in_array($k, $elements) && !is_array($data)) || (isset($elements[$k]) && is_array($data))))
continue;

if (is_array($data))
{
$output[] = '<' . $k . '>';
$output[] = ' ' . Array2XML($data, null, $elements[$k], $indent++);
$output[] = '</' . $k . '>';
}
else
{
if ($data === false)
$data = 0;
elseif ($data === true)
$data = 1;

if (!is_numeric($data))
$output [] = '<' . $k . '><![CDATA[' . $data . ']]></' . $k . '>';
else
$output [] = '<' . $k . '>' . $data . '</' . $k . '>';
}
}
}
Title: Re: SMF Arcade v2.55
Post by: Skhilled on December 31, 2017, 10:46:57 AM
Thanks for posting that, Mick. :)
Title: Re: SMF Arcade v2.55
Post by: Chen Zhen on December 31, 2017, 08:16:23 PM

There isn't a string or array key named comment from the file/line you just referenced.
Anyhow the comment issue should be fixed now.

Ideally this should be tested on:  IE 11, MS Edge, Firefox, Opera, Chrome & Safari.
Those are the leading browsers where javascript behavior can differ.
I only tested this on Ms Edge & Firefox thus far and it seems to be working.

For the moment, I was not able to duplicate the errors you reported.
If they still occur after applying the newer package, please quote the exact error & report it.
Thanks.

Title: Re: SMF Arcade v2.55
Post by: Skhilled on December 31, 2017, 08:49:43 PM
I should have noticed that but have been running back and forth since last night. I don't see "comment" anywhere in the file I have except for "commentform3". Me thinks there's a conflict with another mod, perhaps?

Btw, do you know what game was being played when you got the error?
Title: Re: SMF Arcade v2.55
Post by: lurkalot on January 01, 2018, 05:36:44 AM
Quote from: Chen Zhen on December 31, 2017, 08:16:23 PM

There isn't a string or array key named comment from the file/line you just referenced.
Anyhow the comment issue should be fixed now.

Ideally this should be tested on:  IE 11, MS Edge, Firefox, Opera, Chrome & Safari.
Those are the leading browsers where javascript behavior can differ.
I only tested this on Ms Edge & Firefox thus far and it seems to be working.

For the moment, I was not able to duplicate the errors you reported.
If they still occur after applying the newer package, please quote the exact error & report it.
Thanks.

Thanks, all working ok now, comments working, and edit comments working no errors so far.  Tested in IE11 and Chrome, firefox, and edge.

Great Job.  :cheers:
Title: Re: SMF Arcade v2.55
Post by: Skhilled on January 01, 2018, 05:52:04 AM
Do you know what the problem was?
Title: Re: SMF Arcade v2.55
Post by: lurkalot on January 01, 2018, 06:04:21 AM
Quote from: Skhilled on January 01, 2018, 05:52:04 AM
Do you know what the problem was?

Not sure myself, but whatever Chen Zhen fixed in the last few hours seems to have sorted it, I'm running the latest repo version last updated 3 hours ago.  https://github.com/Underdog-01/SMF-Arcade-RC5/commits/master

I can attach it here if you like?
Title: Re: SMF Arcade v2.55
Post by: Skhilled on January 01, 2018, 06:06:40 AM
Sure, if you want. I had planned on doing it after most of the bugs were sorted but atm, I'm baking Mint Brownie Bars. LOL
Title: Re: SMF Arcade v2.55
Post by: lurkalot on January 01, 2018, 06:10:06 AM
Quote from: Skhilled on January 01, 2018, 06:06:40 AM
Sure, if you want. I had planned on doing it after most of the bugs were sorted but atm, I'm baking Mint Brownie Bars. LOL

Mint Brownie Bars sound good.  :cooking:

OK, I'll attach it to this post, and you can move it to where you want it.  All packaged up and ready to install, with all GitHub stuff removed as normal.  :cheers:
Title: Re: SMF Arcade v2.55
Post by: Skhilled on January 01, 2018, 06:15:47 AM
Thanks, Mick. :)


Now I can relax for about an hour then fix them.
Title: Re: SMF Arcade v2.55
Post by: lurkalot on January 01, 2018, 06:18:27 AM
Quote from: Skhilled on January 01, 2018, 06:15:47 AM
Thanks, Mick. :)


Now I can relax for about an hour then fix them.

Fix them? Fix what Steve, is this a cooking term?
Title: Re: SMF Arcade v2.55
Post by: Skhilled on January 01, 2018, 06:33:16 AM
Technical cooking term. LOL Actually, I should have said finish them...the brownies.
Title: Re: SMF Arcade v2.55
Post by: lurkalot on January 01, 2018, 06:41:01 AM
Quote from: Skhilled on January 01, 2018, 06:33:16 AM
Technical cooking term. LOL Actually, I should have said finish them...the brownies.

Ah, I see, I thought it was cooking related.  In my world, Fix them = Eat them.  :rofl1:

Back on track, haven't spotted anything wrong with the Arcade yet, so all's good so far. Chen Zhen is doing a marvelous job on this, I'm impressed.
Title: Re: SMF Arcade v2.55
Post by: Skhilled on January 01, 2018, 06:47:12 AM
Sounds great. Have you tried the HTML5 games yet?
Title: Re: SMF Arcade v2.55
Post by: lurkalot on January 01, 2018, 06:50:17 AM
Quote from: Skhilled on January 01, 2018, 06:47:12 AM
Sounds great. Have you tried the HTML5 games yet?

No I haven't Steve, where can I find them?  The only ones I've tested are ones that I have on CC, and by the way they are all downloadable from my arcade if there's any you want.  :cheers:
Title: Re: SMF Arcade v2.55
Post by: Skhilled on January 01, 2018, 07:07:17 AM
Sorry, batteries in my mouse died. LOL Some are installed here. I've made you admin in case there were permission issues so you can download them:

https://docskillz.com/arcade/index.php (https://docskillz.com/arcade/index.php)

More can be found using Google and some here:

https://github.com/leereilly/games (https://github.com/leereilly/games)

https://openhtml5games.com/ (https://openhtml5games.com/)

https://superdevresources.com/open-source-html5-games/ (https://superdevresources.com/open-source-html5-games/)


I'm sure Chen Zhen knows where more are.
Title: Re: SMF Arcade v2.55
Post by: lurkalot on January 01, 2018, 07:29:17 AM
Thanks, I'll check them out. ;)
Title: Re: SMF Arcade v2.55
Post by: lurkalot on January 01, 2018, 07:36:20 AM
Tried a html5 one, it uploaded but took a while, quite big by the look of it.  Then got a error when going to manage Installations,

Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 6344795 bytes) in /home/cameracr/public_html/cctestsite.info/forums/Sources/Subs-Package.php on line 412
Title: Re: SMF Arcade v2.55
Post by: Skhilled on January 01, 2018, 07:46:00 AM
Looks like either the code doesn't allow for the size and/or your hosting doesn't allow for it. You may be able to create a php.ini file and adjust it if your hosting will allow you to do it.
Title: Re: SMF Arcade v2.55
Post by: lurkalot on January 01, 2018, 07:51:35 AM
Quote from: Skhilled on January 01, 2018, 07:46:00 AM
Looks like either the code doesn't allow for the size and/or your hosting doesn't allow for it. You may be able to create a php.ini file and adjust it if your hosting will allow you to do it.

Thanks.  Yep need to look into this, it's the first time I've seen this error since moving to new host, so all new to me atm.  Meanwhile I'll see if I can find a smaller one. And to be honest not sure I'm looking at the right sort of game for the arcade, lol.. 
Title: Re: SMF Arcade v2.55
Post by: Skhilled on January 01, 2018, 07:59:05 AM
You can create a phpini.info file to see what your hosting has set for you:

http://support.hostgator.com/articles/phpinfo

That should be allowed even in they do not allow you to use a custom php.ini file. Here's a little more info:

http://support.hostgator.com/articles/what-is-php-ini
Title: Re: SMF Arcade v2.55
Post by: Chen Zhen on January 01, 2018, 11:20:21 AM

You'll have to download it anew again as I just applied the same comment fix to popups which I previously forgot to do.
Are you able to apply the same tests to popups?

Thanks for all your help.
Title: Re: SMF Arcade v2.55
Post by: lurkalot on January 01, 2018, 11:59:11 AM
Quote from: Chen Zhen on January 01, 2018, 11:20:21 AM

You'll have to download it anew again as I just applied the same comment fix to popups which I previously forgot to do.
Are you able to apply the same tests to popups?

Thanks for all your help.

Sure, no problem.  I'll package up a new zip, thanks.  :happy:
Title: Re: SMF Arcade v2.55
Post by: lurkalot on January 01, 2018, 12:13:26 PM
Seems fine so far.  Here's the new zip ready to go again.  :cheers:
Title: Re: SMF Arcade v2.55
Post by: Chen Zhen on January 01, 2018, 07:48:37 PM
When you find HTML5 games that you want adjusted to work with the arcade you will have to either apply the appropriate save fix yourself or create a request thread on my forum.
Games will likely need some other subtle adjustments to function properly and to secure their installation.
ie. adding the appropriate index.php file(s) to protect directories, changing the main index.html to gamename.html and possibly adjusting files that reference the index.html file.

Title: Re: SMF Arcade v2.55
Post by: Chen Zhen on January 01, 2018, 10:08:32 PM
Quote from: lurkalot on January 01, 2018, 07:36:20 AM
Tried a html5 one, it uploaded but took a while, quite big by the look of it.  Then got a error when going to manage Installations,

Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 6344795 bytes) in /home/cameracr/public_html/cctestsite.info/forums/Sources/Subs-Package.php on line 412

You need to opt html5 uploading in the arcade settings.
It uses a method that breaks files down into chunks which allows large file uploads.
Go to: Admin -> Arcade -> Arcade Settings
.. and check-mark the box that says "Use HTML5 Upload Script" then save the settings.
Try uploading a game archive after making that change.
Title: Re: SMF Arcade v2.55
Post by: lurkalot on January 02, 2018, 02:12:12 AM
Quote from: Chen Zhen on January 01, 2018, 10:08:32 PM
Quote from: lurkalot on January 01, 2018, 07:36:20 AM
Tried a html5 one, it uploaded but took a while, quite big by the look of it.  Then got a error when going to manage Installations,

Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 6344795 bytes) in /home/cameracr/public_html/cctestsite.info/forums/Sources/Subs-Package.php on line 412

You need to opt html5 uploading in the arcade settings.
It uses a method that breaks files down into chunks which allows large file uploads.
Go to: Admin -> Arcade -> Arcade Settings
.. and check-mark the box that says "Use HTML5 Upload Script" then save the settings.
Try uploading a game archive after making that change.

Thanks for that info. 

I have a question abut the html5 gamepacks.  I don't usually upload gamepacks and normally opt for just installing the games I want.  But for the purpose of testing the arcade I installed gamepacks 24 / 25.  Some of the games worked, and some didn't can't remember which ones and will have to install again to find out.  There was a couple more that I decided to uninstall for testing this routine.

I noticed that when I uninstalled one game, some of the others stopped working.  Is this normal behavior when working with gamepacks ?
Title: Re: SMF Arcade v2.55
Post by: Chen Zhen on January 02, 2018, 06:17:20 PM

No it is not.
I am able to install all games without one affecting another.
Title: Re: SMF Arcade v2.55
Post by: lurkalot on January 02, 2018, 06:22:39 PM
Thanks.  It was more a case of un-installing one or more games that caused problems with others in the game packs.
Title: Re: SMF Arcade v2.55
Post by: Chen Zhen on January 02, 2018, 09:42:47 PM

So you are reporting that uninstalling multiple games is not working correctly?
Title: Re: SMF Arcade v2.55
Post by: lurkalot on January 03, 2018, 03:19:04 AM
Quote from: Chen Zhen on January 02, 2018, 09:42:47 PM

So you are reporting that uninstalling multiple games is not working correctly?

Chen Zhen I will have to test this again when I get back from work,  but what I found was, just uninstalling one single game from a game pack caused problems with the remaining games in the pack.

Scenario:  I installed game pack 24 - 25 then then found one or two that either didn't work, or I just didn't want.  So went to manage games where all the games from those packs are listed separately as expected.  Ticked box on one of the games and clicked uninstall selected game.  That's when I noticed some of the other html5 games from the packs stopped working.

Title: Re: SMF Arcade v2.55
Post by: lurkalot on January 03, 2018, 03:29:32 PM
OK.  Gave it another test.  This time installed just game pack 24

1: Uploaded gamepack 24
2: Went to manage installations and ticked the box for each game in the pack and clicked install selected. 
3: Tested each game, they all worked except one = Raging Gardens
4: Uninstalled the Raging Gardens game (only).
5: If you look at the screenshot below, you'll see it's removed the thumbs etc from the other games in that pack.  The other games from that pack no longer work.


Title: Re: SMF Arcade v2.55
Post by: Skhilled on January 03, 2018, 11:29:59 PM
Sorry guys! Been very busy with the holidays and birthdays and all...

EDIT: I installed a new test forum and installed gamepack 23. Raging Gardens does work for me but does not save scores nor allows you to view highscores after playing from within the game.

And yes, the images are missing from the other games after uninstalling it. Btw, I was using Chrome.

EDIT 2: I then deleted everything and started over. This time I installed Gamepack 25. Since Raging Gardens was the last game of Gamepack 23, I wondered if the last game in the pack was the one causing problems. So, I immediately went to the last game of the gamepack (25) which was Pacman and played it. It did not save a score and gave this error:

"Score was not saved because session is missing"

I uninstalled it and, again, the images were missing from the other games!
Title: Re: SMF Arcade v2.55
Post by: Chen Zhen on January 04, 2018, 01:45:56 AM

I will have to work on these later in the week or possibly weekend.
The games are saving score but show the error.
Perhaps it is related to the most recent changes I made because it was working previously.
Title: Re: SMF Arcade v2.55
Post by: Skhilled on January 04, 2018, 02:42:20 AM
Ok, if you uninstall any game the icons will be missing. I started anew with a fresh SMF install and uninstalled a different game and the same happened. The game did save the score, saved the comment and also allowed me to edit the comment.

https://docskillz.com/arcade2/index.php?action=arcade
Title: Re: SMF Arcade v2.55
Post by: lurkalot on January 04, 2018, 02:50:25 AM
Quote from: Skhilled on January 04, 2018, 02:42:20 AM
Ok, if you uninstall any game the icons will be missing. I started anew with a fresh SMF install and uninstalled a different game and the same happened. The game did save the score, saved the comment and also allowed me to edit the comment.

https://docskillz.com/arcade2/index.php?action=arcade

Steve, as mentioned above when I uninstalled one of the games, not only did the game thumbs go missing but the other games in the pack stopped working.  Is this not the case for you?  Your other games from that pack continued to work?  Note: I was testing gamepack 24
Title: Re: SMF Arcade v2.55
Post by: Skhilled on January 04, 2018, 06:35:14 AM
Yes, the all games are no longer working. Furthermore, all of the files for all games are deleted but not the directories! I've just checked wondering if any of the files were removed. If you go into "Edit Games" in the admin you'll see "Main File Missing" in red under each game. It appears that the code to remove one game removes them all, perhaps?

EDIT: I just uploaded the games again (except for the one I uninstalled) just to see if more was wrong with it but they all work again. So, it seems all of the files are deleted when you uninstall one of the games.
Title: Re: SMF Arcade v2.55
Post by: lurkalot on January 04, 2018, 12:24:32 PM
Quote from: Skhilled on January 04, 2018, 06:35:14 AM
Yes, the all games are no longer working. Furthermore, all of the files for all games are deleted but not the directories! I've just checked wondering if any of the files were removed. If you go into "Edit Games" in the admin you'll see "Main File Missing" in red under each game. It appears that the code to remove one game removes them all, perhaps?

EDIT: I just uploaded the games again (except for the one I uninstalled) just to see if more was wrong with it but they all work again. So, it seems all of the files are deleted when you uninstall one of the games.

Thanks for the confirmation, glad it's not just me. ;)
Title: Re: SMF Arcade v2.55
Post by: lurkalot on January 06, 2018, 09:58:30 AM
Just a quick question.  Am I right in saying the arcade doesn't have a responsive layout?  Or is this built into one of the alternate themes?
Title: Re: SMF Arcade v2.55
Post by: Skhilled on January 06, 2018, 10:27:18 AM
Good question! I can't remember testing that but will.


EDIT: Not sure if it's responsive or not but all themes seem to work well on my cell and tablets.
Title: Re: SMF Arcade v2.55
Post by: lurkalot on January 06, 2018, 11:32:20 AM
Quote from: Skhilled on January 06, 2018, 10:27:18 AM
Good question! I can't remember testing that but will.


EDIT: Not sure if it's responsive or not but all themes seem to work well on my cell and tablets.

Thanks Steve.  My Firefox updated and I'm now having problems with the responsive design mode.  I'll check again when it starts working again, which hopefully it will. 
Title: Re: SMF Arcade v2.55
Post by: Skhilled on January 06, 2018, 11:36:10 AM
It because of the fixes for Meltdown and Spectre. They kind of mess with the developer mode, atm.
Title: Re: SMF Arcade v2.55
Post by: lurkalot on January 06, 2018, 11:48:57 AM
Quote from: Skhilled on January 06, 2018, 11:36:10 AM
It because of the fixes for Meltdown and Spectre. They kind of mess with the developer mode, atm.

Seems like a lot of sites are have problems over the last couple of days, twitter etc.  Wonder if this is related.
Title: Re: SMF Arcade v2.55
Post by: Skhilled on January 06, 2018, 11:54:46 AM
Probably, either through upgrades/fixes and/or people trying to figure out the exploits. Might be best to wait for the dust to settle...
Title: Re: SMF Arcade v2.55
Post by: Chen Zhen on January 07, 2018, 02:16:11 AM
Quote from: lurkalot on January 06, 2018, 09:58:30 AM
Just a quick question.  Am I right in saying the arcade doesn't have a responsive layout?  Or is this built into one of the alternate themes?

I think he means does it adapt to screen widths.

ie.
The normal format for the vintage list is 4 cells wide.
With a responsive design it might change to 2 cells wide for a tablet or perhaps 1 cell wide for a cell phone.
This way the text and icons can remain a large enough size to be easily seen without squinting to see something reduced too small or scrolling if magnified.

No this design concept is not currently used within the templates & css of the arcade.
However at this time few of the available HTML5 games will work with touch screen controls and most of the games are adobe flash format.
Most mobile devices using main stream browsers do not have flash plugins installed by default mostly due to that process using a lot of battery power quite quickly.
There are less popular browsers that do use it (Imo to draw a user base of people that want/need that feature) and/or 3rd party plugins for mainstream browsers but they are not recommended due to what was just mentioned.

If we are able to introduce many newer HTML5 type games to the arcade that work well on mobile devices (touch screen control) then this would be a good to add.
Title: Re: SMF Arcade v2.55
Post by: lurkalot on January 07, 2018, 05:21:05 AM
Quote from: Chen Zhen on January 07, 2018, 02:16:11 AM
Quote from: lurkalot on January 06, 2018, 09:58:30 AM
Just a quick question.  Am I right in saying the arcade doesn't have a responsive layout?  Or is this built into one of the alternate themes?

I think he means does it adapt to screen widths.

ie.
The normal format for the vintage list is 4 cells wide.
With a responsive design it might change to 2 cells wide for a tablet or perhaps 1 cell wide for a cell phone.
This way the text and icons can remain a large enough size to be easily seen without squinting to see something reduced too small or scrolling if magnified.


Thanks, that was exactly what I was asking. ;) I'll check out those alternate theme settings once I get on to my other PC.
Title: Re: SMF Arcade v2.55
Post by: lurkalot on January 07, 2018, 01:35:05 PM
Just had a quick go on pacman, I only played it once, but this image says different. ;)

Also it froze my IE11 after leaving the game on the page for a minute or two.
Title: Re: SMF Arcade v2.55
Post by: Chen Zhen on January 07, 2018, 04:54:06 PM

I am working on it with a live test on this site.
Locally it works for me but not live.
Title: Re: SMF Arcade v2.55
Post by: Skhilled on January 07, 2018, 05:01:36 PM
Quote from: Skhilled on January 04, 2018, 06:35:14 AM
Yes, the all games are no longer working. Furthermore, all of the files for all games are deleted but not the directories! I've just checked wondering if any of the files were removed. If you go into "Edit Games" in the admin you'll see "Main File Missing" in red under each game. It appears that the code to remove one game removes them all, perhaps?

EDIT: I just uploaded the games again (except for the one I uninstalled) just to see if more was wrong with it but they all work again. So, it seems all of the files are deleted when you uninstall one of the games.

Did you have a look at the above?
Title: Re: SMF Arcade v2.55
Post by: Chen Zhen on January 08, 2018, 09:34:18 PM

The issue regarding uninstalling games that are within a gamepack folder tree should now be resolved.
Please test the new package from my website download section.

Any other reported issues plus some things I noticed myself are still pending at this time. 
Title: Re: SMF Arcade v2.55
Post by: Chen Zhen on January 08, 2018, 09:46:39 PM

The save score issue may be game related or possibly a combo of something in a game & the arcade not checking something.
I just tried papu pakiar & html5 tetris without any issue saving score, however html5 pacman gets caught in a loop.
Something I will mess with this week.
Title: Re: SMF Arcade v2.55
Post by: lurkalot on January 09, 2018, 03:56:12 AM
Quote from: Chen Zhen on January 08, 2018, 09:34:18 PM

Please test the new package from my website download section.


Thank you.  I'm assuming you mean download the new arcade package, and not the game pack from your site downloads?   I don't see any version changes, so never sure if I have the latest. I would normally pick up the latest git repo for testing,  hence my question.

I will give it a test tonight.
Title: Re: SMF Arcade v2.55
Post by: Skhilled on January 09, 2018, 07:56:35 AM
Mick, I believe he means the arcade mod. I just checked Github and can see fixes for the uninstalling of gamepacks  7-10 hours ago. But the dates for the arcade and the gamepacks have not changed on his site...

EDIT: Just installed the Github version and installed the gamepacks I already had and the uninstalling of games works now. Also, Pacman did not freeze on me (using Chrome) and only displayed one highscore.

EDIT #2: I uninstalled Pacman and tried to install it again by uploading the gamepack but got an error stating the gamepack folder was already there. I deleted the folder and the game files within and reinstalled the gamepack. I could play the game but got 2 highscores for the played game this time...using Chrome. Then I noticed that it had installed Pacman twice! LOL

https://docskillz.com/arcade2/index.php?action=arcade (https://docskillz.com/arcade2/index.php?action=arcade)
Title: Re: SMF Arcade v2.55
Post by: Chen Zhen on January 09, 2018, 05:17:46 PM

Just go by the github history to see if I did updates.
I'm not going to bother to increment the version until we're done with bug fixes.
Title: Re: SMF Arcade v2.55
Post by: lurkalot on January 09, 2018, 06:02:59 PM
Quote from: Chen Zhen on January 09, 2018, 05:17:46 PM

Just go by the github history to see if I did updates.
I'm not going to bother to increment the version until we're done with bug fixes.

Thanks.  So to be sure of the latest,  grab it from the git repo as I've been doing. 
Title: Re: SMF Arcade v2.55
Post by: lurkalot on January 14, 2018, 05:43:12 PM
Using latest repo, and all good so far.  Uninstalled one game and all others remained working.  Tried to break it but it's holding up well. http://cctestsite.info/forums/index.php?action=arcade

Only one problem with the raging gardens game. wouldn't work in IE11 but does in other browsers.  Apart from that the arcade itself looks pretty solid. Nice job. 

I'm hoping to soon upgrade my main arcade from SMF Arcade 2.5 RC2 to this new version when it's ready.  Not sure how that will go.
Title: Re: SMF Arcade v2.55
Post by: Chen Zhen on January 14, 2018, 08:00:21 PM

It should go fine as long as you uninstall plus delete the old version first and then upload plus install the newer version.
I still need to do some minor template adjustments that I noticed.
Raging Gardens sounds like an issue with the game itself and is likely not directly related to the Arcade coding.
I will look into Raging Gardens after I complete the template fixes.

Thank you.
Title: Re: SMF Arcade v2.55
Post by: lurkalot on January 15, 2018, 01:48:06 AM
Thanks for info.  You mean just uninstall old arcade, delete package from package manager and upload and install new version? 

I seem to remember years ago when upgrading the arcade I had to clean up my database a bit to get the new one to install, I'm hoping this one won't require this, and should pick up all my games as installed.

I won't be doing this upgrade for a while, as it will probably involve a complete rebuild. lol..
Title: Re: SMF Arcade v2.55
Post by: Skhilled on January 15, 2018, 07:43:57 AM
Mick, you don't have to delete the db, just the old one from Packages. We haven't had to do that in ages.
Title: Re: SMF Arcade v2.55
Post by: lurkalot on January 18, 2018, 06:07:44 PM
Quote from: Skhilled on January 15, 2018, 07:43:57 AM
Mick, you don't have to delete the db, just the old one from Packages. We haven't had to do that in ages.

Sorry for late reply.  Been trying to get my head around that really annoying Tinyportal bug, to no avail I might add.  Going to have to find someone to help me with this, but that's near on impossible these days.

Thanks for the tips regarding upgrading the arcade, yep I would have probably done it that way, just wanted to make sure.  ;)
Title: Re: SMF Arcade v2.55
Post by: Chen Zhen on January 23, 2018, 11:43:09 PM
There are still issues with saving games using Chrome.
I will be looking into this possibly on the weekend.
Title: Re: SMF Arcade v2.55
Post by: Skhilled on January 24, 2018, 07:19:53 AM
Thanks for the update. :)
Title: Re: SMF Arcade v2.55
Post by: Chen Zhen on February 11, 2018, 02:39:22 AM

I changed the pacman game to another HTML5 version that may work for mobile as well (I haven't tested it yet).
I couldn't get the other one to work properly plus the game was not complete anyhow.

Please test out the newer one in the arcade & let me know if it works properly.
I will be fixing Raging Gardens some time this week.
Tetris is also fixed on my site so it does not move the screen when using the arrow keys.
Also let me know if there are problems with any other games whether it be saving score or something else.

Thanks.
Title: Re: SMF Arcade v2.55
Post by: Skhilled on February 11, 2018, 06:15:59 AM
Seems to work well except I got an error in the logs related to the highscores.
Title: Re: SMF Arcade v2.55
Post by: lurkalot on February 11, 2018, 01:16:04 PM
Quote from: Chen Zhen on February 11, 2018, 02:39:22 AM

Tetris is also fixed on my site so it does not move the screen when using the arrow keys.


Glad you noticed this one, I forgot to mention it. Thank you. 
Title: Re: SMF Arcade v2.55
Post by: Chen Zhen on February 11, 2018, 02:29:48 PM
That error has something to do with xml output and no given game id within the url.
I will look into what caused it to use that url without the game id.

Also there is an issue if the score trigger takes longer than 2 seconds because of my score loop check where it will not save the score.
I will have to adjust that subroutine.
Title: Re: SMF Arcade v2.55
Post by: Skhilled on February 11, 2018, 03:15:46 PM
Ok, thanks.
Title: Re: SMF Arcade v2.55
Post by: beast on February 12, 2018, 08:40:31 AM







  If ya got any questions, don't be afraid to ask.  :majornerd: I don't know any thing about it.  :groan:   A course you already knew that  :rofl1: 




   :taz:
Title: Re: SMF Arcade v2.55
Post by: Skhilled on February 12, 2018, 10:41:15 AM
LOL!
Title: Re: SMF Arcade v2.55
Post by: beast on October 23, 2018, 11:40:17 AM
Here is what I got

Installed version: 2.5 RC5
Latest version: 2.56.10 -> Update needed (https://web-develop.ca/index.php?action=downloads;area=stable_smf_arcade;file=1)

I clicked and downloaded this

Now do I just open, and try to install over my old one? Or what? will I lose all my games I have installed?

    :taz:
Title: Re: SMF Arcade v2.55
Post by: Skhilled on October 24, 2018, 08:02:55 AM
It should upgrade the old one. But no matter what you do you won't lose your games unless you manually delete the game files of the database. You'll still have your games. :)
Title: Re: SMF Arcade v2.55
Post by: beast on October 24, 2018, 10:18:13 AM







   It is done, and no trouble at all doing it. Thank you for the advise. I always like to check with you before deleting my whole board as I have in the past.  :hah: :rofl1: :blush:




    :taz:
Title: Re: SMF Arcade v2.55
Post by: Skhilled on October 25, 2018, 07:52:24 AM
I've done it a few times myself! LOL
Title: Re: SMF Arcade v2.55
Post by: lurkalot on November 17, 2018, 05:47:37 AM
Quote from: Chen Zhen on January 14, 2018, 08:00:21 PM

It should go fine as long as you uninstall plus delete the old version first and then upload plus install the newer version.
I still need to do some minor template adjustments that I noticed.


Today I bit the bullet and tried upgrading my arcade.  Didn't quite go as well as I'd hoped. 

Uninstalled:  Skin/PDL for Arcade RC2 and then SMF Arcade 2.5

Then installed: SMF Arcade 2.56.11

All went well and no install errors, visited arcade and even played a game.  Thought I'd try and switch to a different layout for the games. Think I changed the "Select List Type" but can't remember what to.  Anyway on going back to the arcade the Games are not displayed, just a game search.  And where they should be showing it says "No games available for playing"  Can't get the list of games to display at all, but can play them if I search.
Title: Re: SMF Arcade v2.55
Post by: Skhilled on November 17, 2018, 01:20:22 PM
Hi Mick. Did you get the download from here or Chen's site? I haven't upgraded to the latest in the downloads here just yet.  Going to do that now.
Title: Re: SMF Arcade v2.55
Post by: lurkalot on November 17, 2018, 05:42:42 PM
Hi mate.  I got from Chen's site, but think it's sorted now, I believe he replicated the issue and fixed it in the new beta which I'm testing now. Seems fine apart from a couple of missing images.  Still testing atm, and trying to upgrade all sites ready to increase my php version.  I'm still on 5.6  :whistle: